add hotfix for memory error in loadTextureDataFromLodepng

include/ACGL/OpenGL/Data/TextureData.hh

@@ -130,7 +130,7 @@ private:
     // ========================================================================================================= \/
     // ================================================================================================== FIELDS \/
     // ========================================================================================================= \/
-    GLubyte*   mData;
+    GLubyte*   mData;               // TODO: make this a std::unique_ptr to allow custom deleters
     GLsizei    mWidth;
     GLsizei    mHeight;
     GLsizei    mDepth;

src/ACGL/OpenGL/Data/TextureDataLoadStore.cc

@@ -245,14 +245,20 @@ SharedTextureData loadTextureDataFromLodepng(const std::string &_filename, Color
         }
 
         // Decode the image
-        unsigned char* image;
-        errorCode = lodepng_decode_memory(&image, &width, &height, lodepngFile.mData, lodepngFile.mSize, colorType, bitdepth);
+        unsigned char* lodepngImage;
+        errorCode = lodepng_decode_memory(&lodepngImage, &width, &height, lodepngFile.mData, lodepngFile.mSize, colorType, bitdepth);
         if(errorCode)
         {
             std::stringstream errorMsg;
             errorMsg << "LodePNG error while decoding file " << _filename << " - " << errorCode << ": " << lodepng_error_text(errorCode);
             throw std::runtime_error(errorMsg.str());
         }
+        // HOTFIX: TextureData destroys its pointer using delete[], but lodepng uses malloc().
+        // As a hotfix, copy lodepngImage data to a memory location allocated using new[].
+        unsigned int dataSize = width * height * channels * bitdepth / 8;
+        unsigned char* image = new unsigned char[dataSize];
+        memcpy(image, lodepngImage, dataSize);
+        free(lodepngImage);
 
         // LodePNG decodes 16 bit PNGs in big endian format ==> Convert
 #ifndef ACGL_BIG_ENDIAN