Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • G glow-extras
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 0
    • Issues 0
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Glow
  • glow-extras
  • Merge requests
  • !7

Only recreate embedded shader files if existing ones are obsolete

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Jonathan Kunstwald requested to merge feature/add-embed-shader-obsolete-check into master Feb 14, 2019
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Regarding #2 (closed)

Shader embedding files are now only recreated if a shader has changed.

(I have experimented with add_custom_command, but failed to properly set up the dependency relations. The approach i tried is to add a custom command which a) runs cmake -P path/to/embedShader.cmake and b) creates a "stamp" file. Then, a target is added which depends on that stamp file, which is then added as a dependency to the real target (glow-extras-pipeline for example). However, the output of the custom script has to be added as a source file to the target itself, which happens at config time (instead of pre-build). So for now, CMake has to be ran to re-generate embed files. Helpful article: https://samthursfield.wordpress.com/2015/11/21/cmake-dependencies-between-targets-and-files-and-custom-commands/)

Edited Feb 14, 2019 by Jonathan Kunstwald
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: feature/add-embed-shader-obsolete-check