OpenFlipper-Free issueshttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues2017-05-04T12:33:24Zhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/80Vector11T template deduction error on msvc2017-05-04T12:33:24ZChristopher TenterVector11T template deduction error on msvcThere is a strange compile error with the following triangle bsp code:
`TriMeshObject* obj = PluginFunctions::triMeshObject(o_it->id());
TriMeshObject::OMTriangleBSP* bsp = obj->requestTriangleBsp();
TriMeshObject::OMTriangleBSP::Ra...There is a strange compile error with the following triangle bsp code:
`TriMeshObject* obj = PluginFunctions::triMeshObject(o_it->id());
TriMeshObject::OMTriangleBSP* bsp = obj->requestTriangleBsp();
TriMeshObject::OMTriangleBSP::RayCollision rc = bsp->nearestRaycollision(ACG::Vec3d(0.0, 0.0, 0.0), ACG::Vec3d(1.0, 0.0, 0.0));`
Error (vs2015 sp3):
`20>d:\openflipper-free-masterthesis\acg\geometry\bsp\BSPImplT.cc(173): error C2783: 'OpenMesh::VectorT<double,3>::VectorT(T...)': could not deduce template argument for '<unnamed-symbol>'
20> d:\openflipper-free-masterthesis\libs_required\openmesh\src\openmesh\core\geometry\Vector11T.hh(119): note: see declaration of 'OpenMesh::VectorT<double,3>::VectorT'
20> d:\openflipper-free-masterthesis\acg\geometry\bsp\BSPImplT.cc(170): note: while compiling class template member function 'std::vector<std::pair<OpenMesh::FaceHandle,double>,std::allocator<_Ty>> BSPImplT<TriangleBSPCoreT<BSPTraits>>::nearestRaycollision(const OpenMesh::VectorT<double,3> &,const OpenMesh::VectorT<double,3> &) const'
20> with
20> [
20> _Ty=std::pair<OpenMesh::FaceHandle,double>,
20> BSPTraits=OVMOMCommonTriangleBSPTraits<TriMesh,OMSpecificTriangleBSPTraits<TriMesh>>
20> ]
20> D:\OpenFlipper-Free-MasterThesis\Plugin-RasterSurfaceRecon\SceneAnalyzer.cc(171): note: see reference to function template instantiation 'std::vector<std::pair<OpenMesh::FaceHandle,double>,std::allocator<_Ty>> BSPImplT<TriangleBSPCoreT<BSPTraits>>::nearestRaycollision(const OpenMesh::VectorT<double,3> &,const OpenMesh::VectorT<double,3> &) const' being compiled
20> with
20> [
20> _Ty=std::pair<OpenMesh::FaceHandle,double>,
20> BSPTraits=OVMOMCommonTriangleBSPTraits<TriMesh,OMSpecificTriangleBSPTraits<TriMesh>>
20> ]
20> d:\openflipper-free-masterthesis\acg\geometry\bsp\TriangleBSPT.hh(74): note: see reference to class template instantiation 'BSPImplT<TriangleBSPCoreT<BSPTraits>>' being compiled
20> with
20> [
20> BSPTraits=OVMOMCommonTriangleBSPTraits<TriMesh,OMSpecificTriangleBSPTraits<TriMesh>>
20> ]
20> d:\openflipper-free-masterthesis\acg\geometry\bsp\TriangleBSPT.hh(223): note: see reference to class template instantiation 'TriangleBSPT<OVMOMCommonTriangleBSPTraits<Mesh,OMSpecificTriangleBSPTraits<Mesh>>>' being compiled
20> with
20> [
20> Mesh=TriMesh
20> ]
20> D:\OpenFlipper-Free-MasterThesis\Plugin-RasterSurfaceRecon\SceneAnalyzer.cc(171): note: see reference to class template instantiation 'OpenMeshTriangleBSPT<MeshT>' being compiled
20> with
20> [
20> MeshT=TriMesh
20> ]`Janis BornJanis Bornhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/79Fix warning2017-05-04T12:33:24ZJan Möbiusmoebius@cs.rwth-aachen.deFix warninge:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-free\acg\gl\DrawMeshT.cc(263): warning C4267: "return": Konvertierung von "size_t" nach "int", Datenverlust m�glich
131> e:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-...e:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-free\acg\gl\DrawMeshT.cc(263): warning C4267: "return": Konvertierung von "size_t" nach "int", Datenverlust m�glich
131> e:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-free\acg\gl\DrawMeshT.cc(263): note: Bei der Kompilierung der Klassen-template der "int ACG::DrawMeshFaceInput<Mesh>::getNumFaces(void) const"-Memberfunktion
131> with
131> [
131> Mesh=TriMesh
131> ]
131> e:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-free\acg\gl\DrawMeshT.cc(568): note: Siehe Verweis auf die Instanziierung der gerade kompilierten Klassen-template "ACG::DrawMeshFaceInput<Mesh>".
131> with
131> [
131> Mesh=TriMesh
131> ]
131> e:\gitlab\builds\2dad8761\0\openflipper-free\openflipper-free\acg\gl\DrawMeshT.cc(408): note: Bei der Kompilierung der Klassen-template der "void ACG::DrawMeshT<Mesh>::rebuild(void)"-Memberfunktion
131> with
131> [
131> Mesh=TriMesh
131> ]OpenFlipper-4.0https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/78ptr namespace and make_unique2017-05-04T12:33:24ZMartin Heistermannptr namespace and make_uniqueHi,
currently, OF (at ACG/Utils/SmartPointer.hh) and OVM (at System/MemoryInclude.hh) have (nearly?) identical support code to get shared_ptr and unique_ptr from the correct namespace for pre-c++11 compilers.
This should be obsolete now...Hi,
currently, OF (at ACG/Utils/SmartPointer.hh) and OVM (at System/MemoryInclude.hh) have (nearly?) identical support code to get shared_ptr and unique_ptr from the correct namespace for pre-c++11 compilers.
This should be obsolete now in OF (not sure about OVM, will that still support pre-c++11 for the foreseeable future?).
However, support for make_unique [0] would be great - it's very useful, but unfortunately didn't make it into c++ before c++14, but luckily the common non-array version is a straightforward one-liner to implement.
In case OVM does not require pre-c++11 support anymore, I would propose turning ptr from a namespace alias into a proper namespace with adds legacy code support using "using std::unique_ptr" (+shared_ptr, +make_shared - anything else?), and, depending on the C++-version, implements its own basic make_unique.
If not, my suggestion would be putting it somewhere else instead of reusing the old ptr namespace (/namespace alias).
Looking forward to hearing your thoughts on this!
[0] http://en.cppreference.com/w/cpp/memory/unique_ptr/make_uniqueJan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/77Wrong cmake subsystem configuration in console mode on Windows (WIN_GET_DEBU...2017-05-04T12:33:24ZChristopher TenterWrong cmake subsystem configuration in console mode on Windows (WIN_GET_DEBUG_CONSOLE)With the cmake flag WIN_GET_DEBUG_CONSOLE enabled on windows, OpenFlipper starts with a console but no output is ever written to it. This is caused by the misconfigured subsystem flag in the OpenFlipper project properties after running c...With the cmake flag WIN_GET_DEBUG_CONSOLE enabled on windows, OpenFlipper starts with a console but no output is ever written to it. This is caused by the misconfigured subsystem flag in the OpenFlipper project properties after running cmake. So there is actually no debug output in the console.
The subsystem is always set to /SUBYSTEM:WINDOWS, which prevents output streams to the console. The subsystem should be dependent of the WIN_GET_DEBUG_CONSOLE flag to fix this issue. If it is enabled, then /SUBSYSTEM:CONSOLE should be used, otherwise /SUBSYSTEM:WINDOWS.
Apparently it can be controlled by the "WIN32" flag in add_executable()
https://stackoverflow.com/questions/8497948/vs10-always-links-to-subsystemwindows-cmakesdlglewhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/75PropertyVisualizer histograms?2017-05-04T12:33:26ZMartin HeistermannPropertyVisualizer histograms?For me it would be quite useful to compute histograms for property values and on the suggestion of @dbommes I'm currently trying to add support for this to the property visualizer.
Would that be appreciated? I'm asking now, as otherwise...For me it would be quite useful to compute histograms for property values and on the suggestion of @dbommes I'm currently trying to add support for this to the property visualizer.
Would that be appreciated? I'm asking now, as otherwise, I'd save some effort by implementing it in a standalone plugin and wouldn't have to restrict myself to C++98 & Qt4 compat.
I'm currently adding a "show histogram" button to the bottom of the toolbox for appropriate properties (for my purposes, double is enough, but int and bool seem very reasonable too), which would then add a Qwt based histogram inline below, possibly with some controls over bin sizes etc. However I'm very open to suggestions here.
@moebius : If you're interested in this feature, is there some way I could use the CI infrastructure for my own dev branch, so I don't have to duplicate it? (I noticed the CI fails on my PRs as it apparently can't access the git refs in my clone?)https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/73Plugin Convert Meshes2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.dePlugin Convert MeshesConvert between tri and polymesh preserving properties.Convert between tri and polymesh preserving properties.Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/72Plugin-MergeMeshes2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.dePlugin-MergeMeshesPlugin-MergeMeshes
Toolbox icon:
Merge all Target meshes into one mesh.
Ask for new name
Checkbox if old ones should be removed
Preserve properties if possible.
Copy Property function (in OpenMesh)
Ask if different typesPlugin-MergeMeshes
Toolbox icon:
Merge all Target meshes into one mesh.
Ask for new name
Checkbox if old ones should be removed
Preserve properties if possible.
Copy Property function (in OpenMesh)
Ask if different typesMartin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/71More efficient PrincipalAxisNode rendering2017-05-04T12:33:26ZHans-Christian EbkeMore efficient PrincipalAxisNode renderingPrincpialAxisNode (ACG/Scenegraph/PrincipalAxisNode.cc) is rendered in a rather inefficient manner: Axis nodes consist of only 3 colors but every vertex has its individual color. That's some major waste of GPU memory. At the point of thi...PrincpialAxisNode (ACG/Scenegraph/PrincipalAxisNode.cc) is rendered in a rather inefficient manner: Axis nodes consist of only 3 colors but every vertex has its individual color. That's some major waste of GPU memory. At the point of this writing, the file in question is not yet merged into master but in branch move_principal_axis_node_from_physim.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/70Crash when rendering poly lines w/ default internal renderer2017-05-04T12:33:26ZHans-Christian EbkeCrash when rendering poly lines w/ default internal rendererOpenFlipper immediately crashes when displaying poly lines with the default internal renderer. Using the shader pipeline, everything appears to work smoothly.
# Steps to Reproduce
* start OpenFlipper
* set renderer to *Shader Pipe...OpenFlipper immediately crashes when displaying poly lines with the default internal renderer. Using the shader pipeline, everything appears to work smoothly.
# Steps to Reproduce
* start OpenFlipper
* set renderer to *Shader Pipeline*
* open the attached [test.pol](/uploads/ced0dcb7ed7d0f69fcc1209cc9dc0f1f/test.pol)
* the poly line is displayed normally
* switch renderer to *Default Internal*
* *crash*https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/69Broken Shading at Shininess 02017-05-04T12:33:26ZHans-Christian EbkeBroken Shading at Shininess 0Shading of faces is broken if shininess is set to 0.
# Steps to Reproduce
* Open the attached [ra.obj](/uploads/ab67f40db62f4371201751c8a914dd3c/ra.obj) in OpenFlipper.
* Select Shader Pipeline Renderer
* Select Flat Shaded Visuali...Shading of faces is broken if shininess is set to 0.
# Steps to Reproduce
* Open the attached [ra.obj](/uploads/ab67f40db62f4371201751c8a914dd3c/ra.obj) in OpenFlipper.
* Select Shader Pipeline Renderer
* Select Flat Shaded Visualization Mode
* Set Shininess to 1. Result: ![bug1](/uploads/788d10832b72b8ad53391c98f9fb7a13/bug1.png)
* Set Shininess to 0. Result: ![bug2](/uploads/27afff821a2655b4ff4ccb3be17dc38c/bug2.png)https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/68Qt 5.7.0 Crash2017-05-04T12:33:26ZChristopher TenterQt 5.7.0 CrashOpenFlipper compiled with qt 5.7.0 crashes at startup
[trace.txt](/uploads/9950667a4e91ea16176fa0e00450d095/trace.txt)OpenFlipper compiled with qt 5.7.0 crashes at startup
[trace.txt](/uploads/9950667a4e91ea16176fa0e00450d095/trace.txt)https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/67Command line parsing on windows seems to be broken2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.deCommand line parsing on windows seems to be brokenOptions except the filename are ignored. No log output with -cOptions except the filename are ignored. No log output with -cOpenFlipper 3.1Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/65Slice plugin not working with new shaders2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.deSlice plugin not working with new shadersOpenFlipper 3.1https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/64VS2013 Build error2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.deVS2013 Build error61>Time Elapsed 00:00:00.05
8>E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(583): warning C4520: 'PluginFunctions::ObjectReferenceIterator' : multiple default constructors specified
8>E...61>Time Elapsed 00:00:00.05
8>E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(583): warning C4520: 'PluginFunctions::ObjectReferenceIterator' : multiple default constructors specified
8>E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(583): error C2668: 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator' : ambiguous call to overloaded function
8> E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(536): could be 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator(BaseObjectData *,PluginFunctions::IteratorRestriction,DataType)'
8> E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(531): or 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator(PluginFunctions::IteratorRestriction,DataType)'
8> while trying to match the argument list '()'
8> This diagnostic occurred in the compiler generated function 'void PluginFunctions::ObjectReferenceIterator::__dflt_ctor_closure(void)'
8> PluginFunctionsBSplineCurve.cc
8>E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(583): warning C4520: 'PluginFunctions::ObjectReferenceIterator' : multiple default constructors specified
8>E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(583): error C2668: 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator' : ambiguous call to overloaded function
8> E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(536): could be 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator(BaseObjectData *,PluginFunctions::IteratorRestriction,DataType)'
8> E:\JB\workspace\OF-Staging-Win-Gitlab-master\3ea7a0db\OpenFlipper/BasePlugin/PluginFunctions.hh(531): or 'PluginFunctions::ObjectReferenceIterator::ObjectReferenceIterator(PluginFunctions::IteratorRestriction,DataType)'
8> while trying to match the argument list '()'
8> This diagnostic occurred in the compiler generated function 'void PluginFunctions::ObJanis BornJanis Bornhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/63ACG::SceneGraph::BaseNode should implement children_ with std::vector instead...2017-05-04T12:33:26ZHans-Christian EbkeACG::SceneGraph::BaseNode should implement children_ with std::vector instead of std::liststd::list is almost certainly slower than std::vector in any realistic use case.std::list is almost certainly slower than std::vector in any realistic use case.Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/62Plugin-HoleFilling: Selection in toolbox not possible anymore2017-05-04T12:33:26ZHans-Christian EbkePlugin-HoleFilling: Selection in toolbox not possible anymoreIt's not possible anymore to select holes in the table widget of the toolbox. Consequently, it's not possible to use the plugin at all right now.It's not possible anymore to select holes in the table widget of the toolbox. Consequently, it's not possible to use the plugin at all right now.Martin SchultzMartin Schultzhttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/59Supersampling2019-02-07T14:54:31ZChristopher TenterSupersamplingImplement supersampling for high resolution rendering and high quality anti aliasing. Feature should be used for snapshots mostly.Implement supersampling for high resolution rendering and high quality anti aliasing. Feature should be used for snapshots mostly.https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/58OpenFlipper Main Window doesn't remember maximized state2017-05-04T12:33:26ZHans-Christian EbkeOpenFlipper Main Window doesn't remember maximized stateIf OpenFlipper is closed in maximized state, the main window is restored in normal state when starting OpenFlipper again. The maximized state should be restored instead.If OpenFlipper is closed in maximized state, the main window is restored in normal state when starting OpenFlipper again. The maximized state should be restored instead.Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.dehttps://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/57Picking of polylines2017-05-04T12:33:26ZJan Möbiusmoebius@cs.rwth-aachen.dePicking of polylinesPolyline picking is not consisten. Sometimes switching beteween renderers (classic, shader) causes the picking polylines to be removed (Switch to picking renderer and no polylines are visible anymore.)
Furthermore the rendering of li...Polyline picking is not consisten. Sometimes switching beteween renderers (classic, shader) causes the picking polylines to be removed (Switch to picking renderer and no polylines are visible anymore.)
Furthermore the rendering of lines in picking sometimes does not contain the spheres
@ebke : CCOpenFlipper 3.0https://gitlab.vci.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/-/issues/56Crash in Script Editor2017-05-04T12:33:26ZHans-Christian EbkeCrash in Script Editor# Steps to Reproduce
1. Start OpenFlipper
2. Menu "Scripting" -> "Show script editor"
3. Inside the script editor, select any entry in the "Function List". (No need to do anything further. Just any entry has to be selected.)
...# Steps to Reproduce
1. Start OpenFlipper
2. Menu "Scripting" -> "Show script editor"
3. Inside the script editor, select any entry in the "Function List". (No need to do anything further. Just any entry has to be selected.)
4. Close the script editor.
5. Menu "Scripting" -> "Show script editor"
6. *CRASH*Jan Möbiusmoebius@cs.rwth-aachen.deJan Möbiusmoebius@cs.rwth-aachen.de