diff --git a/cmake/CMakeLists.txt b/cmake/CMakeLists.txt index 6dbab6e8d7adebb380127a079e99729c1b8b78b0..e187a3081453f14c2cf1fbabc0a70db7ab8ce271 100644 --- a/cmake/CMakeLists.txt +++ b/cmake/CMakeLists.txt @@ -95,6 +95,7 @@ if (NOT DISABLE_OPENFLIPPER_PYTHON_SYSTEM) endif() if (NOT DISABLE_OPENFLIPPER_PYTHON_SYSTEM) + add_compile_definitions(PYBIND11_NO_ASSERT_GIL_HELD_INCREF_DECREF) #(TODO: Check for GIL errors) if (NOT Python3_FOUND) find_package(Python3 3.11 COMPONENTS Interpreter Development) endif() @@ -144,6 +145,7 @@ set(QT5_REQUIRED_PACKAGES set(QT6_REQUIRED_PACKAGES OpenGLWidgets + Charts # Core5Compat ) @@ -191,6 +193,13 @@ if (${Qt_VERSION_STRING} STRGREATER ${OF_MAX_QT_VERSION}) message(WARNING "Detected QT Version ( ${Qt_VERSION_STRING} ) higher than ${OF_MAX_QT_VERSION}!\n" "OpenFlipper has not been tested with this QT Version.") endif() +# There is a Bug in Qt Charts on lower versions. We need at least 6.5.3. Otherwise the charts are displayed incorrectly. +set (OF_MIN_QT_VERSION "6.5.3") + +if (${OF_MIN_QT_VERSION} STRGREATER ${Qt_VERSION_STRING}) + message(FATAL_ERROR "Detected QT Version ( ${Qt_VERSION_STRING} ) lower than ${OF_MIN_QT_VERSION}!\n" "OpenFlipper requires at least QT Version ${OF_MIN_QT_VERSION}.") +endif() + # ======================================================================== # ========================================================================