Skip to content

RenderObject debug_name was a char* that sometimes pointed to temporary buffers,…

Martin Heistermann requested to merge fix-RO-debugName-UAFs into master

RenderObject debug_name was a char* that sometimes pointed to temporary buffers, change to std::string to ensure proper ownership.

Bug found using ASAN.

std::string can be assigned a const char*, so external code that just sets the attribute to a null-terminated string should still work unchanged.

CI pipeline: https://www.graphics.rwth-aachen.de:9000/OpenFlipper-Free/OpenFlipper-Free/pipelines/7134

Edited by Martin Heistermann

Merge request reports