stripped the changes of QOpenGL branch to use QOpenGLWidgets on Qt5.4 or newer.
As a preparation for the move to Core context support, the QOpenGLWidget classes are used on Qt 5.4 or newer.
However i did not yet check compatibility with Qt 5.3 or older
STATUS: 26.5.17 -> GLError on OSX when rendering a cube (not related to these changes). Seems like Qt version 5.7 and 5.8 are the only affected versions this MR is ready to merge imho
Merge request reports
Activity
I just finished the tests on linux, and you wont like it. I tested on Qt 5.9 beta, Qt 5.8, Qt 5.7, Qt 5.6, Qt 5.5.1, Qt 5.5.0 and for Qt 5.4, Qt 5.3, Qt 5.2.1, Qt 5.2.0 i disabled Propertyvis plugin. I could not compile OpenFlipper with Qt below Qt 5.2.0 as the QCommandlineParser was only introduced in Qt Version 5.2.0
My tests included compiling, and running openFlipper, adding a cube from the primitive generator and rotating it.
5.4 gave a compile error about Q_ENUM with no type and a missing ; in ScriptSettingsVector.hh which is unrelated to this MR so i disabled Plugin Propertyvis.
EDIT: I fixed the GLErrors. But i think we should check the Qt Stereo bug some day, because stereo mode is disabled on quite a number of qt versions. Testing on Windows and osx is still todo.
Edited by Martin Schultzadded 1 commit
- 7dd634fe - added missing gl calls to fix GLErrors with QOpenGLWidget
added 1 commit
- 65a8dbfe - compatibility fixes for QOpenGLWidgets on Qt Version 5.4 and below
added 1 commit
- c3107993 - added compatibility change that i forgot to push
just finished testing on OS X Qt Version 5.7, 5.6 5.5 5.4 5.3 are working, but 5.8 gives a segfault. testing on the preinstalled windows versions gave no error.
will recheck with current master on OS X with 5.8 to see if the error is related to the QOpenGLWidget changes of this MR
Edit: i get the same error when i use the current master, so i think this is unrelated to the current MR
Edited by Martin Schultzadded 10 commits
-
c3107993...edf2c337 - 9 commits from branch
master
- 9b675c0f - Merge branch 'master' into feature_QOpenGLWidget
-
c3107993...edf2c337 - 9 commits from branch
i just checked the GLError situation on OSX and compared it to the current master branch. With Qt 5.8 there are definitely GLErrors on the master branch (e.g. when you add a cube). With Qt 5.9 there are no GLErrors. i am going to open a new issue for this. Since i have seen the GLErrors only on Qt version 5.7 and 5.8 with the changes from this MR, i will check Qt 5.9 with this MR. If there are no GLErrors as well, the GLErrors are unrelated to this MR.
added 7 commits
-
9b675c0f...a2e93c36 - 6 commits from branch
master
- 4d7a0a2b - Merge branch 'master' into feature_QOpenGLWidget
-
9b675c0f...a2e93c36 - 6 commits from branch
mentioned in commit e15fb52b