Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • O OpenFlipper
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributor statistics
    • Graph
    • Compare revisions
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Jobs
  • Commits
Collapse sidebar
  • OpenFlipper-FreeOpenFlipper-Free
  • OpenFlipper
  • Merge requests
  • !69

Fix variable mixup from e8f64be6

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Martin Heistermann requested to merge tex2d-fix-variable-mixup into master Mar 22, 2018
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

Just got this warning:

../OpenFlipper/libs_required/ACG/GL/globjects.cc:643:51: warning: variable 'gltex' is uninitialized when used within its own initialization [-Wuninitialized]
      QImage gltex = ACG::Util::convertToGLFormat(gltex);

Introduced by a recent commit that mixed up two variables:

-      QImage gltex = QGLWidget::convertToGLFormat ( qtex );
+      QImage gltex = ACG::Util::convertToGLFormat(gltex);

I didn't test this change, but it seems clear enough that change was unintended.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: tex2d-fix-variable-mixup