From 1ed0bbec555812d69d80b1460f5d60a383e373ba Mon Sep 17 00:00:00 2001
From: Martin Heistermann <git@mheistermann.de>
Date: Tue, 14 May 2019 17:23:03 +0200
Subject: [PATCH] BoxesNode: improve bounding box calculation, mention
remaining issue
---
Nodes/BoxesNode.cc | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/Nodes/BoxesNode.cc b/Nodes/BoxesNode.cc
index eacd653..237ba2b 100644
--- a/Nodes/BoxesNode.cc
+++ b/Nodes/BoxesNode.cc
@@ -98,9 +98,10 @@ void
BoxesNode::
boundingBox(Vec3d& _bbMin, Vec3d& _bbMax)
{
+ // FIXME: this assumes matrices to only consist of vectors up to unit length
for (const auto &be: elem_) {
- _bbMax.maximize(be.pos + Vec3d(1.,1.,1.));
- _bbMin.minimize(be.pos + Vec3d(-1., -1., -1.));
+ _bbMax.maximize(be.pos + Vec3d(scaleFactor_,scaleFactor_,scaleFactor_));
+ _bbMin.minimize(be.pos + Vec3d(-scaleFactor_, -scaleFactor_, -scaleFactor_));
}
}
--
GitLab