Skip to content
Snippets Groups Projects

new iterators and circulators

Open new iterators and circulators
Plugin-PropertyVis-updated into master
2 unresolved threads
Open Edwin Özdemir requested to merge Plugin-PropertyVis-updated into master
2 unresolved threads

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
OpenMesh/OMPropertyVisualizerIntegerT_impl.hh
93 93 T max = std::numeric_limits<T>::min();
94 94 T min = std::numeric_limits<T>::max();
95 95
96 for (typename MeshT::FaceIter f_it = OMPropertyVisualizer<MeshT>::mesh->faces_begin() ; f_it != OMPropertyVisualizer<MeshT>::mesh->faces_end() ; ++f_it){
97 min = std::min( min, getValue(prop, f_it));
98 max = std::max( max, getValue(prop, f_it));
96 for (auto f_it : OMPropertyVisualizer<MeshT>::mesh->faces()){
97 min = std::min( min, OMPropertyVisualizer<MeshT>::mesh->property(prop, f_it));
  • Jan Möbius
    Jan Möbius @moebius
    Owner

    Maybe we should fix getValue instead of using the property call.

  • Jan Möbius marked this merge request as draft

    marked this merge request as draft

  • Jan Möbius assigned to @eoezdemir and unassigned @moebius

    assigned to @eoezdemir and unassigned @moebius

  • Edwin Özdemir added 1 commit

    added 1 commit

    Compare with previous version

  • Edwin Özdemir marked this merge request as ready

    marked this merge request as ready

  • Jan Möbius
    Jan Möbius @moebius started a thread on the diff
    • OpenMesh/OMPropertyVisualizerInteger.hh
    67 67
    68 68 void removeProperty() override;
    69 69 void duplicateProperty() override;
    70
    71 virtual T getValue(OpenMesh::FPropHandleT< T > prop, typename MeshT::FaceIter iter) { return OMPropertyVisualizer<MeshT>::mesh->property(prop, *iter) ; }
    72 virtual T getValue(OpenMesh::EPropHandleT< T > prop, typename MeshT::EdgeIter iter) { return OMPropertyVisualizer<MeshT>::mesh->property(prop, *iter) ; }
    73 virtual T getValue(OpenMesh::HPropHandleT< T > prop, typename MeshT::HalfedgeIter iter) { return OMPropertyVisualizer<MeshT>::mesh->property(prop, *iter) ; }
    74 virtual T getValue(OpenMesh::VPropHandleT< T > prop, typename MeshT::VertexIter iter) { return OMPropertyVisualizer<MeshT>::mesh->property(prop, *iter) ; }
    70 virtual T getValue(OpenMesh::FPropHandleT< T > prop, typename OpenMesh::SmartFaceHandle iter) { return OMPropertyVisualizer<MeshT>::mesh->property(prop, iter) ; }
    • Jan Möbius
      Jan Möbius @moebius
      Owner

      That seems dangerous on a second thought. Is the mesh stored in the smarthandle always the same as the the mesh used to access the property? Better would be to use the mesh stored in the iterator.

      Needs testing at least.

    • Please register or sign in to reply
    Please register or sign in to reply