cppcheck fixes

SplatCloudObjectSelectionPlugin.cc

@@ -150,7 +150,7 @@ void SplatCloudObjectSelectionPlugin::updateSlotDescriptions()
 //----------------------------------------------------------------
 
 
-void SplatCloudObjectSelectionPlugin::slotSelectionOperation( QString _operation )
+void SplatCloudObjectSelectionPlugin::slotSelectionOperation( const QString& _operation )
 {
   SelectionInterface::PrimitiveType type = 0u;
   emit getActivePrimitiveType( type );

SplatCloudObjectSelectionPlugin.hh

@@ -157,7 +157,7 @@ private slots:
   void noguiSupported() { };
 
   //-- Selection Interface --
-  void slotSelectionOperation( QString _operation );
+  void slotSelectionOperation(const QString &_operation );
 
   void slotToggleSelection     ( QMouseEvent *_event,                 SelectionInterface::PrimitiveType _currentType, bool _deselect );
   void slotSphereSelection     ( QMouseEvent *_event, double _radius, SelectionInterface::PrimitiveType _currentType, bool _deselect );
@@ -243,7 +243,7 @@ private:
 
   bool splatCloudDeleteSelection    ( SplatCloud *_splatCloud,                                                      PrimitiveType _primitiveType                                  ); //!< Delete all selected elements of a SplatCloud
   void splatCloudToggleSelection    ( SplatCloud *_splatCloud, uint _index, ACG::Vec3d &_hit_point,                 PrimitiveType _primitiveType                                  ); //!< Toggle SplatCloud selection
-  void splatCloudSphereSelection    ( SplatCloud *_splatCloud, uint _index, ACG::Vec3d &_hit_point, double _radius, PrimitiveType _primitiveTypes, bool _deselection              ); //!< Use the event to paint selection with a sphere
+  void splatCloudSphereSelection    (SplatCloud *_splatCloud, uint _index, const ACG::Vec3d &_hit_point, double _radius, PrimitiveType _primitiveTypes, bool _deselection              ); //!< Use the event to paint selection with a sphere
   bool splatCloudVolumeSelection    ( SplatCloud *_splatCloud, ACG::GLState &_state, QRegion *_region,              PrimitiveType _primitiveTypes, bool _deselection              ); //!< Surface volume selection tool
   void splatCloudColorizeSelection  ( SplatCloud *_splatCloud,                                                      PrimitiveType _primitiveTypes, int _r, int _g, int _b, int _a ); //!< Colorize the selection
 

SplatCloudObjectSelectionPlugin2.cc

@@ -137,7 +137,7 @@ void SplatCloudObjectSelectionPlugin::splatCloudToggleSelection( SplatCloud *_sp
  * @param _primitiveType primitive types to be selected
  * @param _deselection true, if entities should be deselected
  */
-void SplatCloudObjectSelectionPlugin::splatCloudSphereSelection( SplatCloud *_splatCloud, uint _index, ACG::Vec3d &_hit_point, double _radius, PrimitiveType _primitiveType, bool _deselection )
+void SplatCloudObjectSelectionPlugin::splatCloudSphereSelection( SplatCloud *_splatCloud, uint _index, const ACG::Vec3d &_hit_point, double _radius, PrimitiveType _primitiveType, bool _deselection )
 {
   if( (_primitiveType & vertexType_) == 0 )
     return; // done