Skip to content
Snippets Groups Projects

Fix wrong glBuffer usage

Merged Fix wrong glBuffer usage
glBuffer-bugfixes into master
Merged Martin Heistermann requested to merge glBuffer-bugfixes into master
  1. Jan 12, 2022
    • Martin Heistermann's avatar
      Avoid uninitialized GL buffer in VolumeMeshBufferManager::getBuffer(). · 600d440b
      Martin Heistermann authored 
      When we use glBufferData, we need to recompute the whole buffer.
      600d440b
    • Martin Heistermann's avatar
      Fix picking bug: · 5b77dc47
      Martin Heistermann authored 
      On some GL implementations (mesa software rendering, some AMD cards on
Linux), picking would stop working when switching between pick targets.

The previous logic only updates a buffer when deemed necessary, however
in any case it is first invalidated via glBufferData.

I suppose nvidia graphics, where this worked, did not clear the buffer
and with some luck we got an unchanged buffer.

Fix: only use glBufferData if we actually need to change the buffer.
      5b77dc47