Fixed cppcheck warnings

ObjectTypes/Skeleton/SkeletonObject.cc

@@ -352,8 +352,9 @@ void SkeletonObject::updateIndices(const AnimationHandle &_hAni)
       removeAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str());
       ++i;
       continue;
+    } else {
+      bAdditionalNodes = false;
     }
-    bAdditionalNodes = false;
   }while(bAdditionalNodes);
 }
 
@@ -382,24 +383,25 @@ void SkeletonObject::showIndices(bool _bVisible)
     pMatNode->set_status(ACG::SceneGraph::BaseNode::HideSubtree);
 
   // find and prune redundant nodes
-  unsigned int i = skeleton_->jointCount();
+  unsigned int jointCount = skeleton_->jointCount();
   bool bAdditionalNodes = true;
   do{
     std::stringstream buf;
     std::string nameTransformNode;
 
-    buf << "TextNode " << i << " Transform";
+    buf << "TextNode " << jointCount << " Transform";
     nameTransformNode = buf.str();
 
     ACG::SceneGraph::TransformNode *pTransNode;
     if(getAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str()))
     {
       removeAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str());
-      ++i;
+      ++jointCount;
       continue;
+    } else {
+      bAdditionalNodes = false;
     }
-    bAdditionalNodes = false;
-  }while(bAdditionalNodes);
+  } while(bAdditionalNodes);
 
   // add or update nodes
   PoseT<OpenMesh::Vec3d>* ref = skeleton_->referencePose();
@@ -543,8 +545,9 @@ void SkeletonObject::updateMotionPath(const AnimationHandle &_hAni)
       removeAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str());
       ++i;
       continue;
+    } else {
+      bAdditionalNodes = false;
     }
-    bAdditionalNodes = false;
   }while(bAdditionalNodes);
 }
 
@@ -573,23 +576,24 @@ void SkeletonObject::showMotionPath(bool _visible)
     pMatNode->set_status(ACG::SceneGraph::BaseNode::HideSubtree);
 
   // find and prune redundant nodes
-  unsigned int i = skeleton_->jointCount();
+  unsigned int jointCount = skeleton_->jointCount();
   bool bAdditionalNodes = true;
   do{
     std::stringstream buf;
     std::string nameTransformNode;
 
-    buf << "LineNode " << i << " Transform";
+    buf << "LineNode " << jointCount << " Transform";
     nameTransformNode = buf.str();
 
     ACG::SceneGraph::TransformNode *pTransNode;
     if(getAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str()))
     {
       removeAdditionalNode(pTransNode, "SkeletonPlugin", nameTransformNode.c_str());
-      ++i;
+      ++jointCount;
       continue;
+    } else {
+      bAdditionalNodes = false;
     }
-    bAdditionalNodes = false;
   }while(bAdditionalNodes);
 
 

Plugin-TypeSkeleton/SkeletonBackup.cc

@@ -44,7 +44,7 @@
 
 //-----------------------------------------------------------------------------
 
-SkeletonBackup::SkeletonBackup(SkeletonObject* _skelObj, QString _name, UpdateType _type)
+SkeletonBackup::SkeletonBackup(SkeletonObject* _skelObj, const QString& _name, UpdateType _type)
   : BaseBackup( _skelObj, _name, _type ),
     skelObj_(_skelObj)
 {

Plugin-TypeSkeleton/SkeletonBackup.hh

@@ -53,7 +53,7 @@ class SkeletonBackup : public BaseBackup
 {
 
   public:
-    SkeletonBackup(SkeletonObject* _skelObj, QString _name, UpdateType _type);
+    SkeletonBackup(SkeletonObject* _skelObj, const QString& _name, UpdateType _type);
     ~SkeletonBackup();
 
   public: