1. 14 Apr, 2016 5 commits
    • Jan Möbius's avatar
      Merge branch 'property-manager-factories' into 'master' · 2496fa83
      Jan Möbius authored
      add factory functions for creating PropertyManagers without restating the mesh type in C++11
      
      
      
      See merge request !53
      2496fa83
    • Janis Born's avatar
      4e2ae5be
    • Jan Möbius's avatar
      Merge branch 'fix-nonmanifold-no-collect' into 'master' · 04a01c9e
      Jan Möbius authored
      Not collecting failed faces but directly processing them
      
      **Problem description:**
      
      I encountered severe problems in my application because OpenMesh does not load attributes, such as face texture index, for failed faces (non-manifold geometry).
      Instead of directly handling them, the Importer class defers the handling of failed faces to a post process - but at that point, the attribute information is not available any more, since it is read and applied in the reader, which only deals with the non-failed faces.
      
      
      **Solution:**
      
      My simple solution was to remove the list of failed faces and instead directly handle failed faces inside the "add_face" function of the Importer class.
      
      
      **Discussion:**
      
      I didn't see any drawback, compared to the previous code. It would be interesting to know why the list of failed faces was maintained - was this legacy code, or was there some idea to extend this concept, which was just  never realized? The only functional point that has changed is that I removed the code that adds degenerate faces to the mesh (line 129), since, in my opinion, this makes things just more complicated for some applications, and the benefit of being able to import degenerate faces seems marginal. But that's a design decision, it will be very easy to encapsulate the code that adds a separate face (line 140) into a separate function and use it also for degenerate faces.
      
      It would be great to receive your feedback on this issue, and to know if it is possible to include this change (or something similar).
      
      See merge request !51
      04a01c9e
    • Jan Möbius's avatar
      Updated changelog · 4918d2f3
      Jan Möbius authored
      4918d2f3
    • Janis Born's avatar
  2. 07 Apr, 2016 2 commits
  3. 06 Apr, 2016 1 commit
  4. 05 Apr, 2016 2 commits
  5. 24 Mar, 2016 4 commits
  6. 23 Mar, 2016 4 commits
  7. 21 Mar, 2016 1 commit
  8. 17 Mar, 2016 1 commit
  9. 12 Feb, 2016 2 commits
  10. 11 Feb, 2016 2 commits
  11. 04 Feb, 2016 4 commits
  12. 29 Jan, 2016 2 commits
  13. 18 Jan, 2016 1 commit
  14. 13 Jan, 2016 1 commit
  15. 07 Jan, 2016 1 commit
  16. 06 Jan, 2016 3 commits
  17. 05 Jan, 2016 1 commit
  18. 20 Dec, 2015 1 commit
  19. 17 Dec, 2015 2 commits