Silence warnings caused by gtest.

cmake/ACGCompiler.cmake

@@ -46,9 +46,10 @@ if (UNIX)
   # Warnings
   ################################################################################
   
-  if ("${CMAKE_CXX_COMPILER_ID}" MATCHES ".*Clang.*")
+  if ("${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang")
       list(APPEND ADDITIONAL_CXX_FLAGS "-Weverything")
       list(APPEND ADDITIONAL_CXX_FLAGS "-Wno-c++98-compat")
+      list(APPEND ADDITIONAL_CXX_FLAGS "-Wno-c++98-compat-pedantic")
       list(APPEND ADDITIONAL_CXX_FLAGS "-Wno-padded")
       list(APPEND ADDITIONAL_CXX_FLAGS "-Wno-old-style-cast")
       list(APPEND ADDITIONAL_CXX_FLAGS "-Wno-documentation-unknown-command")

src/Unittests/unittests.cc

-#include <gtest/gtest.h>
-
-#ifdef __clang__
-#  pragma GCC diagnostic ignored "-Weverything"
-#endif
+#include "unittests_common.hh"
 
 int main(int _argc, char** _argv) {
 

src/Unittests/unittests_basics.cc

-#include <gtest/gtest.h>
-#include <Unittests/unittests_common.hh>
+#include "unittests_common.hh"
 
 #include <OpenVolumeMesh/Attribs/StatusAttrib.hh>
 #include <OpenVolumeMesh/Attribs/NormalAttrib.hh>

src/Unittests/unittests_common.hh

 #ifndef INCLUDE_UNITTESTS_COMMON_HH
 #define INCLUDE_UNITTESTS_COMMON_HH
 
-#include <gtest/gtest.h>
 
 #include <OpenVolumeMesh/Mesh/PolyhedralMesh.hh>
 #include <OpenVolumeMesh/Mesh/HexahedralMesh.hh>
@@ -9,11 +8,15 @@
 #include <OpenVolumeMesh/Geometry/VectorT.hh>
 
 #ifdef __clang__
+#  pragma GCC diagnostic ignored "-Weverything"
+#  pragma GCC diagnostic ignored "-Wundef"
 #  pragma GCC diagnostic ignored "-Wglobal-constructors"
 #  pragma GCC diagnostic ignored "-Wzero-as-null-pointer-constant"
-#  pragma GCC diagnostic ignored "-Wundef"
+#  pragma GCC diagnostic ignored "-Wmissing-noreturn"
 #endif
 
+#include <gtest/gtest.h>
+
 #define EXPECT_HANDLE_EQ(a, b)  EXPECT_EQ((a).idx(), (b).idx())
 #define EXPECT_HANDLE_NE(a, b)  EXPECT_NE((a).idx(), (b).idx())
 

src/Unittests/unittests_files.cc

-#include <gtest/gtest.h>
-#include <Unittests/unittests_common.hh>
+#include "unittests_common.hh"
 
 #include <OpenVolumeMesh/FileManager/FileManager.hh>
 

src/Unittests/unittests_iterators.cc

-#include <gtest/gtest.h>
+#include "unittests_common.hh"
 
-#include <Unittests/unittests_common.hh>
 
 using namespace OpenVolumeMesh;
 

src/Unittests/unittests_properties.cc

 
 #include <iostream>
 
-#include <gtest/gtest.h>
-
 #include "unittests_common.hh"
 
 #include <OpenVolumeMesh/Attribs/StatusAttrib.hh>

src/Unittests/unittests_smartptr.cc

-#include <gtest/gtest.h>
+#include "unittests_common.hh"
 
 #if __cplusplus >= 201103L || _MSC_VER >= 1800