Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • OpenVolumeMesh OpenVolumeMesh
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 28
    • Issues 28
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • OpenVolumeMeshOpenVolumeMesh
  • OpenVolumeMeshOpenVolumeMesh
  • Merge requests
  • !3
The source project of this merge request has been removed.

WIP: Fix deferred vertex deletion, add unit test.

Closed Martin Heistermann requested to merge (removed):fix-deferred-delete into master Aug 29, 2016
  • Overview 3
  • Pipelines 0
  • Changes 2

GeometryKernel::collect_garbage used to first perform the TopologyKernel garbage collection, usually shrinking its vertex_deleted_ member, then accesses it using is_deleted() with the old vertex indices.

This causes out-of-bounds memory access (made visible by cmake -DSTL_VECTOR_CHECKS=ON) and wrong results, the remaining vertices will have the wrong coordinates.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-deferred-delete