Skip to content
Snippets Groups Projects

Fix several bugs with the STL reader

Merged Julius Nehring-Wirxel requested to merge jn/develop into develop

On windows ifstreams handle data differently depending if the file was opened in binary mode or not. This messed with the parsing for some files.

Fixed reading a binary file into any other scalar type other than float. Binary STL always contain 32 bit floats, but the parser depended on ScalarT for how much data should be read, which can lead to false results if e.g. a double position type is given.

Merge request reports

Merged by Philip TrettnerPhilip Trettner 4 years ago (Jan 25, 2021 7:37pm UTC)

Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading