Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • P polymesh
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 4
    • Issues 4
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 1
    • Merge requests 1
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Philip Trettner
  • polymesh
  • Merge requests
  • !30

Fix several bugs with the STL reader

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Julius Nehring-Wirxel requested to merge jn/develop into develop Jan 25, 2021
  • Overview 0
  • Commits 1
  • Pipelines 0
  • Changes 1

On windows ifstreams handle data differently depending if the file was opened in binary mode or not. This messed with the parsing for some files.

Fixed reading a binary file into any other scalar type other than float. Binary STL always contain 32 bit floats, but the parser depended on ScalarT for how much data should be read, which can lead to false results if e.g. a double position type is given.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: jn/develop